WeSign/unity-application
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Resolve WES-XXX "Courses and minigames list fix" #110

Merged
dvschuyl merged 2 commits from WES-XXX-Courses-and-minigames-list-fix into development 2023-05-18 14:15:14 +00:00
Conversation 16 Commits 2 Files Changed 5 +876 -17
dvschuyl commented 2023-05-18 08:41:14 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Description

  • Added so when adding new courses or minigames, they are visible in the lists.
  • Update logo

Testing Instructions

For the lists:

  1. Go to the CourseListScreen in Playmode
  2. Add in the editor some extra course items (by duplicated the existing so they are already initialized)
  3. See the scroll bar appear when there are at least 9 items, and disappear when there are at most 8.
  4. Repeat for the MinigameListScreen

For the logo:

  1. Check the new logo in editor and build

Related Issues

None

Known bugs or issues

None

Checklist

  • I have filled in this template.
  • I have tested my changes thoroughly (both in the editor + build and run (ctrl+B)!).
  • [~] I have added appropriate unit tests.
  • [~] I have added appropriate playmode tests.
  • [~] I have updated the user documentation as necessary.
  • Code reviewed by 2 people.

Additional Notes

@carl Please don't kill me 😥.

## Description - Added so when adding new courses or minigames, they are visible in the lists. - Update logo ## Testing Instructions For the lists: 1. Go to the CourseListScreen in Playmode 2. Add in the editor some extra course items (by duplicated the existing so they are already initialized) 3. See the scroll bar appear when there are at least 9 items, and disappear when there are at most 8. 4. Repeat for the MinigameListScreen For the logo: 1. Check the new logo in editor and build ## Related Issues _None_ ## Known bugs or issues _None_ ## Checklist - [X] I have filled in this template. - [X] I have tested my changes thoroughly (both in the editor + **build and run (ctrl+B)**!). - [~] I have added appropriate unit tests. - [~] I have added appropriate playmode tests. - [~] I have updated the user documentation as necessary. - [ ] Code reviewed by 2 people. ## Additional Notes @carl Please don't kill me 😥.
dvschuyl commented 2023-05-18 08:41:14 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

requested review from @louadria, @tihabils, @dvschuyl, @lvrossem, @hvbreuge, @jeldgees, and @jrcoudro

requested review from @louadria, @tihabils, @dvschuyl, @lvrossem, @hvbreuge, @jeldgees, and @jrcoudro
jrcoudro (Migrated from gitlab.ilabt.imec.be) approved these changes 2023-05-18 08:41:14 +00:00
hvbreuge (Migrated from gitlab.ilabt.imec.be) approved these changes 2023-05-18 08:41:14 +00:00
dvschuyl commented 2023-05-18 08:44:39 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

changed target branch from main to development

changed target branch from `main` to `development`
dvschuyl commented 2023-05-18 08:46:24 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

changed title from {-W-}es{- xxx c-}ourses and minigames list fix to {+R+}es{+olve WES-XXX "C+}ourses and minigames list fix{+"+}

changed title from **{-W-}es{- xxx c-}ourses and minigames list fix** to **{+R+}es{+olve WES-XXX "C+}ourses and minigames list fix{+"+}**
dvschuyl commented 2023-05-18 08:48:42 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

marked this merge request as draft

marked this merge request as **draft**
dvschuyl commented 2023-05-18 08:54:29 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

changed the description

changed the description
dvschuyl commented 2023-05-18 09:05:05 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>1a20212b - Updated logo</li></ul> [Compare with previous version](/wesign/unity-application/-/merge_requests/110/diffs?diff_id=43378&start_sha=b9bdcac6c4565e854c6ed90bd8b9fedf500eefe3)
dvschuyl commented 2023-05-18 09:06:03 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

marked this merge request as ready

marked this merge request as **ready**
hvbreuge commented 2023-05-18 09:47:01 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Looks good. My only remark is that when there are more than 8 possible courses or minigames, the scene starts with a view on the middle row and not the top.
afbeelding

Looks good. My only remark is that when there are more than 8 possible courses or minigames, the scene starts with a view on the middle row and not the top. ![afbeelding](/uploads/0f5469c6cbb8ada523af9a0209ae1677/afbeelding.png)
hvbreuge commented 2023-05-18 13:20:46 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

approved this merge request

approved this merge request
dvschuyl commented 2023-05-18 13:22:11 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

It is impossible in Unity to have both centering for 4 or fewer items and the scroll bar at the top for 9 or more items.

It is impossible in Unity to have both centering for 4 or fewer items and the scroll bar at the top for 9 or more items.
dvschuyl commented 2023-05-18 13:22:13 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

resolved all threads

resolved all threads
jrcoudro commented 2023-05-18 14:15:04 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Looks good, no problems with tests either

Looks good, no problems with tests either
jrcoudro commented 2023-05-18 14:15:06 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

approved this merge request

approved this merge request
jrcoudro commented 2023-05-18 14:15:13 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

mentioned in commit 74d73ba648

mentioned in commit 74d73ba6481021c600c28edbb0ebf98a3ff1a39f
Sign in to join this conversation.
Reviewers
No Reviewers
jrcoudro
hvbreuge
Labels
Clear labels
bug
enhancement
impact::high
impact::low
impact::minor
impact::moderate
impact::very low
probability::high
probability::low
probability::minor
probability::moderate
probability::very low
progress::busy
progress::done
progress::review
progress::todo
version::0.1
version::0.2
version::0.3
version::0.4
version::0.5
version::1.0
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
VictorMylle
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WeSign/unity-application#110
No description provided.
Delete Branch "WES-XXX-Courses-and-minigames-list-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?