WeSign/sign-predictor
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases 3 Wiki Activity

Rotation augmentation class added #15

Merged
robdwael merged 0 commits from WES-123-rotation-augmentation into dev 2023-04-24 11:57:21 +00:00
Conversation 5 Commits - Files Changed -
robdwael commented 2023-04-08 07:31:04 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Description

Added the rotation augmentation class
This augmentation rotates all keypoints around (0,0)

Testing Instructions

  1. Open the visualize_data notebook
  2. Call the plot_keypoints function with the rotation augmentation in the arguments

Make sure you test it on normalized keypoints

Once you've tested the changes, please confirm that they work as expected and that there are no regressions or unexpected side effects. If any issues are discovered during testing, please include detailed steps to reproduce the issue in the merge request comments. Thank you!

Related Issues

Known bugs or issues

Checklist

  • I have filled in this template.
  • I have tested my changes thoroughly.
  • I have updated the user documentation as necessary.
  • Code reviewed by 1 person.

Additional Notes

Rotation augmentation is only applicable on normalized keypoints

Closes WES-123

## Description Added the rotation augmentation class This augmentation rotates all keypoints around (0,0) ## Testing Instructions 1. Open the visualize_data notebook 2. Call the plot_keypoints function with the rotation augmentation in the arguments Make sure you test it on normalized keypoints _Once you've tested the changes, please confirm that they work as expected and that there are no regressions or unexpected side effects. If any issues are discovered during testing, please include detailed steps to reproduce the issue in the merge request comments. Thank you!_ ## Related Issues ## Known bugs or issues ## Checklist - [x] I have filled in this template. - [x] I have tested my changes thoroughly. - [x] I have updated the user documentation as necessary. - [x] Code reviewed by 1 person. ## Additional Notes Rotation augmentation is only applicable on normalized keypoints Closes WES-123
robdwael commented 2023-04-08 07:31:21 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

changed the description

changed the description
robdwael commented 2023-04-08 07:32:07 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

marked this merge request as ready

marked this merge request as **ready**
robdwael commented 2023-04-23 16:29:56 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

requested review from @vimylle

requested review from @vimylle
vimylle commented 2023-04-24 11:57:18 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

marked the checklist item Code reviewed by 1 person. as completed

marked the checklist item **Code reviewed by 1 person.** as completed
vimylle commented 2023-04-24 11:57:20 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

mentioned in commit cd9cc8ce8b

mentioned in commit cd9cc8ce8b8c8481e273f5b717284f63bfcc3c94
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
enhancement
impact::high
impact::low
impact::minor
impact::moderate
impact::very low
probability::high
probability::low
probability::minor
probability::moderate
probability::very low
progress::busy
progress::done
progress::review
progress::todo
version::0.1
version::0.2
version::0.3
version::0.4
version::0.5
version::1.0
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
VictorMylle
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WeSign/sign-predictor#15
Delete Branch "WES-123-rotation-augmentation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?