WeSign/unity-application
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Fixed course freezing and other course-ending bugs #92

Merged
jrcoudro merged 0 commits from WES-203-Course-freezing into development 2023-05-08 21:38:47 +00:00
Conversation 8 Commits - Files Changed -
jrcoudro commented 2023-05-08 18:59:45 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Description

Bugs surrounding courses are fixed now.

Testing Instructions

  1. Play a whole course
  2. Check if endScreen-panel and infopage of completed course works

Related Issues

WES-187

Known bugs or issues

Hopefully none

Checklist

  • I have filled in this template.
  • I have tested my changes thoroughly (both in the editor + build and run (ctrl+B)!).
  • [~] I have added appropriate unit tests.
  • [~] I have added appropriate playmode tests.
  • I have updated the user documentation as necessary.
  • Code reviewed by 2 people.

Closes WES-203

## Description Bugs surrounding courses are fixed now. ## Testing Instructions 1. Play a whole course 2. Check if endScreen-panel and infopage of completed course works ## Related Issues WES-187 ## Known bugs or issues Hopefully none ## Checklist - [x] I have filled in this template. - [x] I have tested my changes thoroughly (both in the editor + **build and run (ctrl+B)**!). - [~] I have added appropriate unit tests. - [~] I have added appropriate playmode tests. - [x] I have updated the user documentation as necessary. - [ ] Code reviewed by 2 people. Closes WES-203
jeldgees (Migrated from gitlab.ilabt.imec.be) approved these changes 2023-05-08 18:59:45 +00:00
dvschuyl (Migrated from gitlab.ilabt.imec.be) approved these changes 2023-05-08 18:59:45 +00:00
jrcoudro commented 2023-05-08 18:59:46 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

requested review from @louadria, @tihabils, @dvschuyl, @lvrossem, @hvbreuge, @jeldgees, and @jrcoudro

requested review from @louadria, @tihabils, @dvschuyl, @lvrossem, @hvbreuge, @jeldgees, and @jrcoudro
dvschuyl commented 2023-05-08 19:26:44 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Looks very good!

Looks very good!
dvschuyl commented 2023-05-08 19:26:46 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

approved this merge request

approved this merge request
jeldgees commented 2023-05-08 21:32:34 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Seem to working fine

Seem to working fine
jeldgees commented 2023-05-08 21:32:41 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

approved this merge request

approved this merge request
jeldgees commented 2023-05-08 21:38:46 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

mentioned in commit 672ff367e2

mentioned in commit 672ff367e25218d93333605ab4f2c653d45b61a0
Sign in to join this conversation.
Reviewers
No Reviewers
jeldgees
dvschuyl
Labels
Clear labels
bug
enhancement
impact::high
impact::low
impact::minor
impact::moderate
impact::very low
probability::high
probability::low
probability::minor
probability::moderate
probability::very low
progress::busy
progress::done
progress::review
progress::todo
version::0.1
version::0.2
version::0.3
version::0.4
version::0.5
version::1.0
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
VictorMylle
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WeSign/unity-application#92
Delete Branch "WES-203-Course-freezing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?