WeSign/unity-application
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Fixed screen scaling #82

Merged
louadria merged 0 commits from UI-resolution-fix into development 2023-04-11 16:04:08 +00:00
Conversation 9 Commits - Files Changed -
louadria commented 2023-04-11 15:00:38 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Description

Made screen scaling possible, so free aspect is supported.

Testing Instructions

In the editor, in the game panel, choose resolution->free-aspect. Scaling should be applied and the app should look good on most normal acceptable resolutions.

Once you've tested the changes, please confirm that they work as expected and that there are no regressions or unexpected side effects. If any issues are discovered during testing, please include detailed steps to reproduce the issue in the merge request comments. Thank you!

Related Issues

None

Known bugs or issues

_None

Checklist

  • I have filled in this template.
  • I have tested my changes thoroughly (both in the editor + build and run (ctrl+B)!).
  • I have added appropriate unit tests.
  • I have updated the user documentation as necessary.
  • Code reviewed by 2 people.

Additional Notes

## Description Made screen scaling possible, so free aspect is supported. ## Testing Instructions In the editor, in the game panel, choose resolution->free-aspect. Scaling should be applied and the app should look good on most normal acceptable resolutions. Once you've tested the changes, please confirm that they work as expected and that there are no regressions or unexpected side effects. If any issues are discovered during testing, please include detailed steps to reproduce the issue in the merge request comments. Thank you! ## Related Issues _None_ ## Known bugs or issues _None ## Checklist - [X] I have filled in this template. - [X] I have tested my changes thoroughly (both in the editor + **build and run (ctrl+B)**!). - [X] I have added appropriate unit tests. - [X] I have updated the user documentation as necessary. - [ ] Code reviewed by 2 people. ## Additional Notes
louadria commented 2023-04-11 15:00:38 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

requested review from @louadria, @tihabils, @dvschuyl, @lvrossem, @hvbreuge, @jeldgees, and @jrcoudro

requested review from @louadria, @tihabils, @dvschuyl, @lvrossem, @hvbreuge, @jeldgees, and @jrcoudro
jeldgees (Migrated from gitlab.ilabt.imec.be) approved these changes 2023-04-11 15:00:38 +00:00
jrcoudro (Migrated from gitlab.ilabt.imec.be) approved these changes 2023-04-11 15:00:38 +00:00
jrcoudro commented 2023-04-11 15:01:15 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

approved this merge request

approved this merge request
louadria commented 2023-04-11 15:02:36 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

requested review from @vimylle

requested review from @vimylle
louadria commented 2023-04-11 15:15:44 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

changed the description

changed the description
jeldgees commented 2023-04-11 15:41:51 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

seems fine

seems fine
jeldgees commented 2023-04-11 15:41:53 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

approved this merge request

approved this merge request
louadria commented 2023-04-11 16:04:08 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

mentioned in commit 77850bfbe6

mentioned in commit 77850bfbe6d46f7d4eebf3b27434e456e7bc2df6
Sign in to join this conversation.
Reviewers
No Reviewers
jrcoudro
jeldgees
Labels
Clear labels
bug
enhancement
impact::high
impact::low
impact::minor
impact::moderate
impact::very low
probability::high
probability::low
probability::minor
probability::moderate
probability::very low
progress::busy
progress::done
progress::review
progress::todo
version::0.1
version::0.2
version::0.3
version::0.4
version::0.5
version::1.0
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
VictorMylle
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WeSign/unity-application#82
Delete Branch "UI-resolution-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?