WeSign/unity-application
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Fix bug #80

Merged
dvschuyl merged 0 commits from WES-XX-persistent-data-controller-backwards-compatible into development 2023-04-08 19:24:47 +00:00
Conversation 10 Commits - Files Changed -
dvschuyl commented 2023-04-08 09:34:45 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Description

Fixed a bug with incorrect version of stored data.

Testing Instructions

The EditMode test will test for you whether this is correctly implemented. However, if you want to test it for yourself, go to the location of the saved .json data file on your disk and change the version number (increase or decrease) and now the application will generate a new file.

Related Issues

None

Known bugs or issues

None

Checklist

  • I have filled in this template.
  • I have tested my changes thoroughly (both in the editor + build and run (ctrl+B)!).
  • I have added appropriate unit tests.
  • I have updated the user documentation as necessary.
  • Code reviewed by 2 people.

Additional Notes

None

## Description Fixed a bug with incorrect version of stored data. ## Testing Instructions The EditMode test will test for you whether this is correctly implemented. However, if you want to test it for yourself, go to the location of the saved `.json` data file on your disk and change the version number (increase or decrease) and now the application will generate a new file. ## Related Issues _None_ ## Known bugs or issues _None_ ## Checklist - [X] I have filled in this template. - [X] I have tested my changes thoroughly (both in the editor + **build and run (ctrl+B)**!). - [X] I have added appropriate unit tests. - [X] I have updated the user documentation as necessary. - [x] Code reviewed by 2 people. ## Additional Notes _None_
dvschuyl commented 2023-04-08 09:34:45 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

requested review from @louadria, @tihabils, @dvschuyl, @lvrossem, @hvbreuge, @jeldgees, and @jrcoudro

requested review from @louadria, @tihabils, @dvschuyl, @lvrossem, @hvbreuge, @jeldgees, and @jrcoudro
louadria (Migrated from gitlab.ilabt.imec.be) approved these changes 2023-04-08 09:34:45 +00:00
jrcoudro (Migrated from gitlab.ilabt.imec.be) approved these changes 2023-04-08 09:34:45 +00:00
jrcoudro commented 2023-04-08 14:24:31 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Seems to work fine, the old file gets overwritten but I assume this is intentional.

Seems to work fine, the old file gets overwritten but I assume this is intentional.
jrcoudro commented 2023-04-08 14:24:33 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

approved this merge request

approved this merge request
dvschuyl commented 2023-04-08 15:26:03 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

It will only be overwritten when you have an incorrect version in your savefile. You reviewed !77 and there the version is increased. By reviewing this merge request, you sort of proved that my changes work 😄 .

It will only be overwritten when you have an incorrect version in your savefile. You reviewed !77 and there the version is increased. By reviewing this merge request, you sort of proved that my changes work :smile: .
dvschuyl commented 2023-04-08 15:29:02 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

resolved all threads

resolved all threads
louadria commented 2023-04-08 19:24:29 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

marked the checklist item Code reviewed by 2 people. as completed

marked the checklist item **Code reviewed by 2 people.** as completed
louadria commented 2023-04-08 19:24:29 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

approved this merge request

approved this merge request
dvschuyl commented 2023-04-08 19:24:47 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

mentioned in commit 73c4756f19

mentioned in commit 73c4756f19980d8c046649b2669c8a0c0da88231
Sign in to join this conversation.
Reviewers
No Reviewers
louadria
jrcoudro
Labels
Clear labels
bug
enhancement
impact::high
impact::low
impact::minor
impact::moderate
impact::very low
probability::high
probability::low
probability::minor
probability::moderate
probability::very low
progress::busy
progress::done
progress::review
progress::todo
version::0.1
version::0.2
version::0.3
version::0.4
version::0.5
version::1.0
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
VictorMylle
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WeSign/unity-application#80
Delete Branch "WES-XX-persistent-data-controller-backwards-compatible"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?