WeSign/unity-application
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Theme descriptions added #109

Merged
hvbreuge merged 0 commits from WES-167-theme-descriptions into development 2023-05-17 15:52:17 +00:00
Conversation 10 Commits - Files Changed -
hvbreuge commented 2023-05-16 20:03:44 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Description

Added the theme descriptions again for clothes, animals, hobbies, food, and house.
I don't remember what clothes said before and don't like the current, so open to suggestions

Testing Instructions

Main menu > minigames > SpellingBee > Start > Read descriptions for themes
Main menu > minigames > JustSign > Start > Read descriptions for themes

Once you've tested the changes, please confirm that they work as expected and that there are no regressions or unexpected side effects. If any issues are discovered during testing, please include detailed steps to reproduce the issue in the merge request comments. Thank you!

Related Issues

WES-176-User-manual

Known bugs or issues

Checklist

  • I have filled in this template.
  • I have tested my changes thoroughly (both in the editor + build and run (ctrl+B)!).
  • [~] I have added appropriate unit tests.
  • [~] I have added appropriate playmode tests.
  • [~] I have updated the user documentation as necessary.
  • Code reviewed by 2 people.

Additional Notes

Closes WES-167

## Description Added the theme descriptions again for clothes, animals, hobbies, food, and house. I don't remember what clothes said before and don't like the current, so open to suggestions ## Testing Instructions Main menu > minigames > SpellingBee > Start > Read descriptions for themes Main menu > minigames > JustSign > Start > Read descriptions for themes Once you've tested the changes, please confirm that they work as expected and that there are no regressions or unexpected side effects. If any issues are discovered during testing, please include detailed steps to reproduce the issue in the merge request comments. Thank you! ## Related Issues WES-176-User-manual ## Known bugs or issues ## Checklist - [x] I have filled in this template. - [x] I have tested my changes thoroughly (both in the editor + **build and run (ctrl+B)**!). - [~] I have added appropriate unit tests. - [~] I have added appropriate playmode tests. - [~] I have updated the user documentation as necessary. - [ ] Code reviewed by 2 people. ## Additional Notes Closes WES-167
hvbreuge commented 2023-05-16 20:03:44 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

requested review from @louadria, @tihabils, @dvschuyl, @lvrossem, @hvbreuge, @jeldgees, and @jrcoudro

requested review from @louadria, @tihabils, @dvschuyl, @lvrossem, @hvbreuge, @jeldgees, and @jrcoudro
dvschuyl (Migrated from gitlab.ilabt.imec.be) approved these changes 2023-05-16 20:03:44 +00:00
jeldgees (Migrated from gitlab.ilabt.imec.be) approved these changes 2023-05-16 20:03:44 +00:00
jrcoudro commented 2023-05-16 20:38:39 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

"Gebarentaal is in dit jaar", how bout that

"Gebarentaal is in dit jaar", how bout that
jrcoudro commented 2023-05-16 20:38:41 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

approved this merge request

approved this merge request
jrcoudro commented 2023-05-16 20:59:16 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

unapproved this merge request

unapproved this merge request
jeldgees commented 2023-05-17 14:06:11 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

Looks good! i dont mind the description of clothing

Looks good! i dont mind the description of clothing
jeldgees commented 2023-05-17 14:06:13 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

approved this merge request

approved this merge request
dvschuyl commented 2023-05-17 15:52:05 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

approved this merge request

approved this merge request
dvschuyl commented 2023-05-17 15:52:17 +00:00 (Migrated from gitlab.ilabt.imec.be)
Copy Link

mentioned in commit 3dded6c3e6

mentioned in commit 3dded6c3e698a6d62654eb47ed0f939cb194e21d
Sign in to join this conversation.
Reviewers
No Reviewers
dvschuyl
jeldgees
Labels
Clear labels
bug
enhancement
impact::high
impact::low
impact::minor
impact::moderate
impact::very low
probability::high
probability::low
probability::minor
probability::moderate
probability::very low
progress::busy
progress::done
progress::review
progress::todo
version::0.1
version::0.2
version::0.3
version::0.4
version::0.5
version::1.0
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
VictorMylle
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: WeSign/unity-application#109
Delete Branch "WES-167-theme-descriptions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?